Update setup instructions in login_and_acl.md #2851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised instructions for enabling access control on search index, clarifying conditions based on index existence.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the setup instructions for enabling authentication and access control by reordering the steps to align with the automated deployment behavior. The key change moves the manual ACL enablement step from before deployment to after authentication setup, clarifying that it's only needed for pre-existing indexes since new indexes automatically get ACL fields during deployment.
Key Changes:
- Moved the "Enable access control on your search index" step from before deployment (after step 2) to after authentication tenant login (before the final deployment step)
- Clarified that manual ACL enablement is only needed if the search index already exists
- Added explicit note that ACLs are automatically enabled during deployment for new indexes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mattgotteiner
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #2849
The steps currently say to run "enable_acls" before you have run azd up. This PR changes it to say to only run that if your index already exists.
Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.
Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
Type of change
Code quality checklist
See CONTRIBUTING.md for more details.
N/A